-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI: finish public api of arcade.gui.property #2014
Conversation
…for simple callbacks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My overall impression is good and I like callbacks. I have one change to suggest and a question.
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
TL;DR: After fixing my suggestion typo, merge as-is if you or einarf think it's fine I'm not yet sure on the type annotations for this. My instinct is that there is something we can do to polish it, but I may also be wrong. Getting it merged and working takes priority over perfect types, however. It's not breaking anything else as far as I can tell, and the stricter type checkers aren't something we're in full compliance with yet anyway. |
Co-authored-by: Paul <36696816+pushfoo@users.noreply.github.com>
properties provide instance and value to listener (keep support for simple callbacks)